Skip to content

[Translation] [Bridge] [Lokalise] do not export empty strings #43312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

[Translation] [Bridge] [Lokalise] do not export empty strings #43312

merged 1 commit into from
Oct 4, 2021

Conversation

taranovegor
Copy link
Contributor

@taranovegor taranovegor commented Oct 4, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? no
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

This change excludes the possibility of receiving strings without translation. At the moment, all keys that have no translation in the Lokalise panel are empty strings after export.
Link to documentation describing the added parameter: https://app.lokalise.com/api2docs/curl/#transition-download-files-post

example w/o changes:
Screenshot 2021-10-04 at 16 59 04
validators.es.xlf
Screenshot 2021-10-04 at 17 15 09

TODO:

  • Changelog

@carsonbot carsonbot added this to the 5.3 milestone Oct 4, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

welcoMattic
welcoMattic approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@welcoMattic welcoMattic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taranovegor, I think it's ok to accept this fix, because we want to fallback to the fallback locale as soon as possible when a translation is empty.

@derrabus
Copy link
Member

derrabus commented Oct 4, 2021

Thank you @taranovegor.

@derrabus derrabus merged commit fb8d537 into symfony:5.3 Oct 4, 2021
@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Translation
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@taranovegor @carsonbot @derrabus @stof @welcoMattic