Skip to content

[MonologBridge] Deprecates ResetLoggersWorkerSubscriber #43322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[MonologBridge] Deprecates ResetLoggersWorkerSubscriber #43322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Symfony/Bridge/Monolog/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
CHANGELOG
=========

5.4
---

* Deprecate `ResetLoggersWorkerSubscriber` to reset buffered logs in messenger
workers, use "reset_on_message" option in messenger configuration instead.

5.3
---

Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Bridge/Monolog/Messenger/ResetLoggersWorkerSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@
use Symfony\Component\Messenger\Event\WorkerMessageFailedEvent;
use Symfony\Component\Messenger\Event\WorkerMessageHandledEvent;

trigger_deprecation('symfony/monolog-bridge', '5.4', 'The "%s" class is deprecated, use "reset_on_message" option in messenger configuration instead.', ResetLoggersWorkerSubscriber::class);

/**
* Reset loggers between messages being handled to release buffered handler logs.
*
* @author Laurent VOULLEMIER <laurent.voullemier@gmail.com>
*
* @deprecated since Symfony 5.4, use "reset_on_message" option in messenger configuration instead.
*/
class ResetLoggersWorkerSubscriber implements EventSubscriberInterface
{
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bridge/Monolog/Tests/Messenger/ResetLoggersWorkerSubscriberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
use Symfony\Component\Messenger\Transport\Receiver\ReceiverInterface;
use Symfony\Component\Messenger\Worker;

/** @group legacy */
class ResetLoggersWorkerSubscriberTest extends TestCase
{
public function testLogsAreFlushed()
Expand Down