Skip to content

[Cache][Lock] fix SQLSRV throws for method_exists() #43330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

GDmac
Copy link
Contributor

@GDmac GDmac commented Oct 5, 2021

pdo_sqlsrv driver 5.9.0 always throws an exception for any call on method_exists().
(see microsoft/msphpsql/issues/1306)

executeStatement() is a DBAL-method, and exec() is PDO.
fix by excluding method_exists() on PDO type of connections

Q A
Branch? 4.4 (and later)
Bug fix? yes
New feature? no
Deprecations? no
License MIT

pdo_sqlsrv driver 5.9.0 throws an exception for any call on method_exists().
(see microsoft/msphpsql/issues/1306)
executeStatement() is a DBAL-method, exec() is PDO.
fix by excluding method_exists() check on PDO type of connections
@GDmac GDmac requested a review from jderusse as a code owner October 5, 2021 20:30
@carsonbot carsonbot added this to the 4.4 milestone Oct 5, 2021
@carsonbot carsonbot changed the title fix SQLSRV throws for method_exists() [Cache][Lock] fix SQLSRV throws for method_exists() Oct 5, 2021
@derrabus
Copy link
Member

derrabus commented Oct 5, 2021

Thank you @GDmac.

@derrabus derrabus merged commit 37d26fb into symfony:4.4 Oct 5, 2021
This was referenced Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants