Skip to content

[HttpFoundation] Fix PHP 8.1 deprecation notice in IpUtils::checkIp() #43357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2021
Merged

[HttpFoundation] Fix PHP 8.1 deprecation notice in IpUtils::checkIp() #43357

merged 1 commit into from
Oct 10, 2021

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Oct 7, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #43350
License MIT
Doc PR

After this PR got merged I will create additional PRs to deprecate (5.4)/remove (6.0) passing null to various methods in IpUtils like suggested in #43350 (comment)

@carsonbot carsonbot added this to the 5.3 milestone Oct 7, 2021
@W0rma W0rma mentioned this pull request Oct 7, 2021
Closed
@derrabus derrabus modified the milestones: 5.3, 4.4 Oct 7, 2021
@derrabus
Copy link
Member

derrabus commented Oct 7, 2021

👍🏻 But let's fix this on 4.4.

@derrabus derrabus mentioned this pull request Oct 7, 2021
Closed
@W0rma W0rma force-pushed the 43350-php81-iputils branch from 46a72ed to 870ea00 Compare October 7, 2021 12:27
@W0rma W0rma changed the base branch from 5.3 to 4.4 October 7, 2021 12:27
@W0rma
Copy link
Contributor Author

W0rma commented Oct 7, 2021

👍🏻 But let's fix this on 4.4.

Thank you for the hint. I rebased against 4.4

@W0rma W0rma mentioned this pull request Oct 7, 2021
Merged
@derrabus derrabus closed this Oct 7, 2021
@derrabus derrabus reopened this Oct 7, 2021
@W0rma W0rma force-pushed the 43350-php81-iputils branch from 870ea00 to 5e991db Compare October 7, 2021 15:31
@fabpot
Copy link
Member

fabpot commented Oct 10, 2021

Thank you @W0rma.

@fabpot fabpot merged commit ab7884c into symfony:4.4 Oct 10, 2021
@fabpot
Copy link
Member

fabpot commented Oct 10, 2021

@W0rma Can you work on the followup PRs?

@W0rma W0rma deleted the 43350-php81-iputils branch October 10, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youssefsaoubou youssefsaoubou youssefsaoubou left review comments

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@W0rma @derrabus @fabpot @youssefsaoubou @chalasr @carsonbot