Skip to content

[BUG] PoFileLoader pluralhandling uses interval instead of index. #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2012

Conversation

clemens-tolboom
Copy link
Contributor

PoFileLoaders parsed Gettext messages as interval but should have used indexed.

I added index only message strings to MessageSelectorTest to reflect this.

(this is part of #4249)

@travisbot
Copy link

This pull request passes (merged 4c4d889 into 58b9245).

fabpot added a commit that referenced this pull request May 19, 2012
Commits
-------

4c4d889 Fixed PoFileLoader pluralhandling from interval to index.

Discussion
----------

[BUG] PoFileLoader pluralhandling uses interval instead of index.

PoFileLoaders parsed Gettext messages as interval but should have used indexed.

I added index only message strings to MessageSelectorTest to reflect this.

(this is part of #4249)

---------------------------------------------------------------------------

by travisbot at 2012-05-19T10:11:09Z

This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373653) (merged 4c4d889 into 58b9245).
@fabpot fabpot merged commit 4c4d889 into symfony:master May 19, 2012
craigmarvelley pushed a commit to craigmarvelley/symfony that referenced this pull request Nov 26, 2013
…ony#4339)

Commits
-------

fb6cf3e Allow for missing whitelines.

Discussion
----------

Allow for missing whitelines.

The Gettext specification allows for 'whitespace is optional' between message string.

For this to work PoFileLoader needs to save found messages on more places while processing. Thus a new method is introduced.

For the tests to work PoFileDumper was changed slightly to only emit white-lines when necessary.

I added more documentation from the GNU gettext documentation to make the code more understandable.

When [[BUG] PoFileLoader pluralhandling uses interval instead of index.](symfony#4336) this patch needs some small rework.

(this is part of [[WIP]: Allow Drupal to use Translate component)](symfony#4249)

---------------------------------------------------------------------------

by travisbot at 2012-05-19T12:44:19Z

This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374295) (merged fb6cf3e into 58b9245).

---------------------------------------------------------------------------

by stof at 2012-05-19T13:19:29Z

you need to rebase your branch. github tells us it cannot be merged automatically
@clemens-tolboom clemens-tolboom deleted the pofileloader-pluralhandling branch December 23, 2013 10:07
SerhiyMytrovtsiy pushed a commit to SerhiyMytrovtsiy/translation that referenced this pull request Oct 19, 2022
Commits
-------

fb6cf3e Allow for missing whitelines.

Discussion
----------

Allow for missing whitelines.

The Gettext specification allows for 'whitespace is optional' between message string.

For this to work PoFileLoader needs to save found messages on more places while processing. Thus a new method is introduced.

For the tests to work PoFileDumper was changed slightly to only emit white-lines when necessary.

I added more documentation from the GNU gettext documentation to make the code more understandable.

When [[BUG] PoFileLoader pluralhandling uses interval instead of index.](symfony/symfony#4336) this patch needs some small rework.

(this is part of [[WIP]: Allow Drupal to use Translate component)](symfony/symfony#4249)

---------------------------------------------------------------------------

by travisbot at 2012-05-19T12:44:19Z

This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374295) (merged fb6cf3ef into 58b92453).

---------------------------------------------------------------------------

by stof at 2012-05-19T13:19:29Z

you need to rebase your branch. github tells us it cannot be merged automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants