Skip to content

[HttpFoundation] Deprecate upload_progress.* and url_rewriter.tags session options #43378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

[HttpFoundation] Deprecate upload_progress.* and url_rewriter.tags session options #43378

merged 1 commit into from
Oct 13, 2021

Conversation

kafene
Copy link

@kafene kafene commented Oct 8, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets Fix #43284
License MIT

Related to issue #43284.

Deprecate support for configuring session.upload_progress.* - these options are PHP_INI_PERDIR options and can not be configured at runtime via ini_set.

Deprecate support for configuring url_rewriter.tags - as of PHP 7.1.0, this option is no longer used for session configuration and that setting is now session.trans_sid_tags. url_rewriter.tags is used only by output_add_rewrite_var.

I wasn't sure about writing a test for this. I couldn't find any other places that deprecation notices were being tested. However the existing HttpFoundation test uses url_rewriter.tags and I can see the new deprecation notice when running php ./phpunit src/Symfony/Component/HttpFoundation/ -- it may be appropriate to update that to use a new option.

@carsonbot carsonbot added this to the 5.4 milestone Oct 8, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think @Guite has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Oct 10, 2021

@kafene Can you fix the tests as they are using some deprecated options which make the tests fail?

@fabpot fabpot force-pushed the deprecate_session_upload_progress branch from 76af0e4 to da02720 Compare October 13, 2021 06:03
@fabpot
Copy link
Member

fabpot commented Oct 13, 2021

Thank you @kafene.

@fabpot fabpot merged commit 603ccac into symfony:5.4 Oct 13, 2021
@fabpot fabpot mentioned this pull request Oct 13, 2021
Closed
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Deprecation HttpFoundation Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[HttpFoundation] Deprecate session.upload_progress.* and url_rewriter.tags as valid configuration options.
3 participants
@kafene @carsonbot @fabpot