Skip to content

[DependencyInjection] Extend TaggedIterator and TaggedLocator Attributes with able to specify defaultIndexMethod for #[TaggerIterator] and #[TaggedLocator] #43386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

[DependencyInjection] Extend TaggedIterator and TaggedLocator Attributes with able to specify defaultIndexMethod for #[TaggerIterator] and #[TaggedLocator] #43386

merged 1 commit into from
Oct 19, 2021

Conversation

fractalzombie
Copy link
Contributor

@fractalzombie fractalzombie commented Oct 10, 2021 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bugfix? no
New feature? yes (updated)
Deprecations? no
Tickets no ticket, the only contribution for fun and enjoy
License MIT
Doc PR no, it's not a new feature, this we can do through YAML, but not through new PHP attributes, now we can do it through attributes.

Just extended one attribute that do not break compatibility, is optional and null.
The feature only allows you to do almost the same as in YAML files, the configuration specifying defaultIndexMethod for:

-  \ Symfony \ Component \ DependencyInjection \ Attribute \ TaggedIterator
-  \ Symfony \ Component \ DependencyInjection \ Attribute \ TaggedLocator

@carsonbot carsonbot added this to the 6.0 milestone Oct 10, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think @l-vo has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fractalzombie
Copy link
Contributor Author

Hey hello! Can somebody review this PR?)

@fractalzombie
Copy link
Contributor Author

fractalzombie commented Oct 15, 2021 •
edited
Loading

@nicolas-grekas Done :) Add some new tests for all of the cases with TaggedIterator and TaggedLocator with defaultIndexMethod, defaultPriorityMethod, and both of them together.

@fractalzombie
Copy link
Contributor Author

Hello!) Can some one review PR please?)

@nicolas-grekas nicolas-grekas modified the milestones: 6.0, 5.4 Oct 18, 2021
@fabpot
Copy link
Member

fabpot commented Oct 18, 2021

@fractalzombie Can you change the target to 5.4? Thank you.

@fractalzombie fractalzombie changed the base branch from 6.0 to 5.4 October 18, 2021 18:54
@fractalzombie fractalzombie changed the base branch from 5.4 to 6.0 October 18, 2021 18:55
@fractalzombie
Copy link
Contributor Author

@fractalzombie Can you change the target to 5.4? Thank you.

Many conflict files, or it's ok for now?

@nicolas-grekas
Copy link
Member

Yes, please fix the conflicts while rebasing. We'll handle the reverse conflicts when merging 5.4 into 6.0.

@fractalzombie fractalzombie changed the base branch from 6.0 to 5.4 October 18, 2021 21:06
@fractalzombie
Copy link
Contributor Author

fractalzombie commented Oct 19, 2021 •
edited
Loading

Yes, please fix the conflicts while rebasing. We'll handle the reverse conflicts when merging 5.4 into 6.0.

Solve conflicts, for now it's all is ok)

nicolas-grekas
nicolas-grekas approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please apply fabbot's patch and we'll be good!

@fractalzombie
[DependencyInjection] Extend TaggedIterator and TaggedLocator Attribu…
8c4651a 
…tes with able to specify defaultIndexMethod and defaultPriorityMethod for #[TaggerIterator] and #[TaggedLocator]
@fractalzombie
Copy link
Contributor Author

Thanks, please apply fabbot's patch and we'll be good!

Done :)

@fabpot
Copy link
Member

fabpot commented Oct 19, 2021

Thank you @fractalzombie.

@fabpot fabpot mentioned this pull request Oct 19, 2021
Closed
@fabpot fabpot merged commit f36d0e0 into symfony:5.4 Oct 19, 2021
@fractalzombie
Copy link
Contributor Author

Thank you @fractalzombie.

Thanks to you guys too.

@Okhoshi Okhoshi mentioned this pull request Oct 20, 2021
Merged
1 task
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@chalasr chalasr Awaiting requested review from chalasr

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fractalzombie @carsonbot @fabpot @nicolas-grekas