Skip to content

[Bridge][Monolog] Add intruction about 'ResetLoggersWorkerSubscriber deprecation' in main UPGRADE-5.4.md #43406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

[Bridge][Monolog] Add intruction about 'ResetLoggersWorkerSubscriber deprecation' in main UPGRADE-5.4.md #43406

merged 1 commit into from
Oct 12, 2021

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Oct 12, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I forgot to edit this file in my previous PR. I'm not sure If it should tho. So feel free to close it if it's not required

@carsonbot carsonbot added this to the 5.4 milestone Oct 12, 2021
@lyrixx lyrixx requested a review from chalasr October 12, 2021 08:56
@chalasr
Copy link
Member

chalasr commented Oct 12, 2021

UPGADE-6.0 also needs an entry about the removal, right?

@lyrixx
Copy link
Member Author

lyrixx commented Oct 12, 2021

I did it in #43405, is it OK?

@chalasr
Copy link
Member

chalasr commented Oct 12, 2021

The UPGRADE-6.0 entry should be moved here (but not the CHANGELOG one)

@lyrixx lyrixx force-pushed the messenger-and-log-5-4 branch from 6ed1aa7 to cf3e01c Compare October 12, 2021 09:02
@lyrixx
Copy link
Member Author

lyrixx commented Oct 12, 2021

OK, it should be OK now (and the other PR too)

@fabpot
Copy link
Member

fabpot commented Oct 12, 2021

Thank you @lyrixx.

@fabpot fabpot merged commit 8757fdd into symfony:5.4 Oct 12, 2021
@lyrixx lyrixx deleted the messenger-and-log-5-4 branch October 12, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @chalasr @fabpot @carsonbot