Skip to content

[Notifier] Fix 'Undefined array key' error in FirebaseTransport #43408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

[Notifier] Fix 'Undefined array key' error in FirebaseTransport #43408

merged 1 commit into from
Oct 12, 2021

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Oct 12, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42841
License MIT
Doc PR n/a

This modification fixes a remaining Undefined array key error in FirebaseTransport.
It also add a test to cover #42690.

@villfa villfa requested a review from OskarStark as a code owner October 12, 2021 10:40
@carsonbot carsonbot added this to the 5.3 milestone Oct 12, 2021
@fabpot
Copy link
Member

fabpot commented Oct 12, 2021

Thank you @villfa.

@fabpot fabpot merged commit d867a45 into symfony:5.3 Oct 12, 2021
@villfa villfa deleted the fix/42841 branch October 12, 2021 11:28
@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@villfa @fabpot @carsonbot