Skip to content

[HttpFoundation] Deprecate passing null as $requestIp in IpUtils #43411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2021
Merged

[HttpFoundation] Deprecate passing null as $requestIp in IpUtils #43411

merged 1 commit into from
Oct 16, 2021

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Oct 12, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets #43350 (comment)
License MIT
Doc PR

@carsonbot carsonbot added this to the 5.4 milestone Oct 12, 2021
@carsonbot
Copy link

Hey!

I think @a-menshchikov has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

derrabus
derrabus requested changes Oct 13, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this topic!

Let's avoid the checkIp() if the IP to check is null. We already know the result.

@W0rma W0rma force-pushed the deprecate-null-iputils-check-ip branch 2 times, most recently from 2bac0cf to dca654d Compare October 15, 2021 17:15
@W0rma W0rma force-pushed the deprecate-null-iputils-check-ip branch from dca654d to 55e3a5b Compare October 15, 2021 17:19
@W0rma W0rma requested a review from derrabus October 15, 2021 17:24
@fabpot
Copy link
Member

fabpot commented Oct 16, 2021

Thank you @W0rma.

@fabpot fabpot merged commit a53a173 into symfony:5.4 Oct 16, 2021
@W0rma W0rma mentioned this pull request Oct 17, 2021
Merged
fabpot added a commit that referenced this pull request Oct 18, 2021
@fabpot
feature #43550 [HttpFoundation] Remove possibility to pass null as $r…
be8401b 
…equestIp in IpUtils (W0rma)

This PR was merged into the 6.0 branch.

Discussion
----------

[HttpFoundation] Remove possibility to pass null as $requestIp in IpUtils

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #43350 (comment)
| License       | MIT
| Doc PR        |

Removes the code which was deprecated in #43411

Commits
-------

e95e97d Remove possibility to pass null as $requestIp in IpUtils
This was referenced Nov 5, 2021
Merged
Merged
@W0rma W0rma deleted the deprecate-null-iputils-check-ip branch November 7, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Deprecation HttpFoundation Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@W0rma @carsonbot @fabpot @derrabus