[DependencyInjection] autowire union and intersection types #43479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea29ed6 to
9830bd3
Compare
dunglas
approved these changes
Oct 13, 2021
9830bd3 to
aba31f9
Compare
ogizanagi
approved these changes
Oct 13, 2021
chalasr
approved these changes
Oct 13, 2021
derrabus
approved these changes
Oct 13, 2021
|
Thank you Nicolas. |
2 tasks
This was referenced Nov 5, 2021
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2021
… together with `ServiceSubscriberInterface` (kbond) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix support for unions/intersections together with `ServiceSubscriberInterface` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Continuation of #43479 per [discussion](#43913 (comment)) with `@nicolas`-grekas. Todo: - [x] intersection type support/tests - [x] `ServiceSubscriberTrait` support Commits ------- 123842a [DependencyInjection] Fix support for unions/intersections together with `ServiceSubscriberInterface`
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2022
…message (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] fix expected autowiring exception message | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | types are sorted since #43479 in 5.4+ Commits ------- 1373257 fix expected autowiring exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows autowiring an argument of type
NormalizerInterface&DenormalizerInterfaceif both individual types have a corresponding autowiring alias, and if both aliases point to the very same service.This works the same with union types.