[Messenger] Fix Redis Transport when username is empty #43484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
I think, we need to fix this on 4.4 again. |
|
@derrabus The PR is rebased onto 4.4. |
|
@villfa Thank you for the PR. Can you please force-push again to trigger the CI? |
|
@chalasr I closed and reopened the PR and that did the trick apparently. |
welcoMattic
reviewed
Oct 14, 2021
src/Symfony/Component/Messenger/Tests/Transport/RedisExt/ConnectionTest.php
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Oct 24, 2021
welcoMattic
approved these changes
Oct 24, 2021
|
Thank you @villfa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the username and the password with
issetis not enough. We also need to check they're not empty strings.This fixes the BC break introduced by #43124.
See also https://3v4l.org/iASnE