Skip to content

[Notifier] [Twilio] Ensure from/sender is valid via regex #43497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2021
Merged

[Notifier] [Twilio] Ensure from/sender is valid via regex #43497

merged 1 commit into from
Oct 15, 2021

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

I also spotted some missing tests for ClickatellTransport, so I added them to this PR.

@OskarStark OskarStark requested a review from fabpot October 14, 2021 09:51
@OskarStark OskarStark self-assigned this Oct 14, 2021
@carsonbot carsonbot changed the title [Notifier][Twilio] Ensure from/sender is valid via regex [Notifier] [Twilio] Ensure from/sender is valid via regex Oct 14, 2021
@carsonbot carsonbot added this to the 5.4 milestone Oct 14, 2021
@OskarStark OskarStark force-pushed the fix/sender-id branch 7 times, most recently from 6e6d300 to 52a4da3 Compare October 14, 2021 11:12
@fabpot
Copy link
Member

fabpot commented Oct 15, 2021

Thank you @OskarStark.

@fabpot fabpot mentioned this pull request Oct 15, 2021
Closed
@fabpot fabpot merged commit f7e2fa2 into symfony:5.4 Oct 15, 2021
@OskarStark OskarStark deleted the fix/sender-id branch October 15, 2021 09:46
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees

@OskarStark OskarStark

Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @fabpot @carsonbot