[Framework][Assets] Set assets manifest strict by default on debug #43517
Conversation
| @@ -79,7 +79,7 @@ | |||
| ->args([ | |||
| abstract_arg('manifest path'), | |||
| service('http_client')->nullOnInvalid(), | |||
| false, | |||
There was a problem hiding this comment.
This default value was discussed with @weaverryan in #38495 (comment)
There was a problem hiding this comment.
Hmm, this may makes sense. However, it's a BC break: on 5.4 if I have a path that isn't included, then on 6.0, I'll suddenly have an error. Also, there may be people who are putting some of their files directly public/ and, for those files, they won't be in manifest.json and that's ok. I think we probably can't make this change
|
That's a good point. People may rely on this fallback behaviour to mix assets listed and not listed in the manifest.json, using a single asset package. Should it be considered as a good practice? This use-case will still be supported, but require the option strict_mode to be set to false explicitly. I could add a deprecation in 5.4? |
|
Hmm, the question is: is strict mode such a better default that it’s worth the pain of deprecating it and forcing people to turn it to true. I’m not convinced that it is. So I’m 👎 for making this the default. |
|
In particular, I don't think that the strict mode should be related to |
assets.strict_modemake it easier to debug when an asset is missing from the manifest. Usingkernel.debugas default value would release developers from configuring this option (symfony/demo#1168).This is consistent with Twig environment that is strict on debug by default.