Add a warning in WDT when using symfony/symfony #43526
Conversation
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twig
Outdated
Show resolved
Hide resolved
4b5451a to
f7d4494
Compare
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twig
Show resolved
Hide resolved
|
Any reason to not add |
|
@ro0NL We will still tag the |
|
I wouldn't mark the package as "abandoned" in Composer/Packagist, because many non-savvy users will understand it as if the entire Symfony project is abandoned. We should avoid that confusion and bad marketing for the project at all costs. |
|
@javiereguiluz Note that Packagist allows to provide a replacement for the abandoned package, which could be symfony/flex here. |
|
Yes, but that would be confusing too 😭 Has Symfony project renamed to Flex? Has it merged with a different project called Flex? The thing is that for many non-experts, symfony/symfony repo is Symfony. |
…'s needed by toolbar.html.twig (weaverryan) This PR was merged into the 5.4 branch. Discussion ---------- [5.4][WebProfiler] Fixing missing full_stack variable that's needed by toolbar.html.twig | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | None | License | MIT | Doc PR | Not needed The combination of #43526 and then #41257 created an undefined variable. By adding the variable here, it will flow from `toolbar_js.html.twig` into `toolbar.html.twig`. Tested locally after reproducing the issue. Thanks to symfony/ux test suite for catching this :) Commits ------- 0e8b864 Fixing missing full_stack variable that's needed by toolbar.html.twig
Even if using the
symfony/symfonypackage is still possible, it is highly discouraged. It comes with limitations that cannot be fixed (when you are using Mailer/Notifier/Messenger bridges for instance). It also makes the code slower for no good reasons and makes you download all possible Symfony packages even if you are not using them.This has been the case since 4.0, it's time to warn people that they should upgrade ASAP.
We are adding a warning as we will still be tagging
symfony/symfonyfor the next major versions as these tags help the maintainers.