Skip to content

[Lock] Fix incorrect return type in PostgreSqlStore #43589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2021
Merged

[Lock] Fix incorrect return type in PostgreSqlStore #43589

merged 1 commit into from
Oct 26, 2021

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 19, 2021

Q A
Branch? 5.3
Bug fix? no
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

Reported by Psalm:

ERROR: UndefinedInterfaceMethod - src/Symfony/Component/Lock/Store/PostgreSqlStore.php:235:36 - Method Symfony\Component\Lock\PersistingStoreInterface::saveRead does not exist (see https://psalm.dev/181)
        $this->getInternalStore()->saveRead($key);

@GromNaN GromNaN requested a review from jderusse as a code owner October 19, 2021 14:28
@carsonbot carsonbot added this to the 5.3 milestone Oct 19, 2021
@fabpot
Copy link
Member

fabpot commented Oct 26, 2021

Thank you @GromNaN.

@fabpot fabpot merged commit a14ef91 into symfony:5.3 Oct 26, 2021
@stof
Copy link
Member

stof commented Oct 26, 2021

@GromNaN do we have the same issue in 5.4 in the DBAL one after the split ?

@GromNaN
Copy link
Member Author

GromNaN commented Oct 26, 2021

That was fixed in the new DoctrineDbalPostgreSqlStore class. https://github.com/symfony/symfony/pull/43332/files#diff-50dca0072996d11d6a0c1c9ffb1ed6240b733eccce1da32667998b76a784b9a1R229

@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Lock Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
6 participants
@GromNaN @fabpot @stof @jderusse @chalasr @carsonbot