[Config] Fix files sorting in GlobResource #43591
Conversation
It should be on path and not on info and it's a big perf boost: https://blackfire.io/profiles/compare/27f409a5-73c7-4285-9b58-e631abbdb325/graph
|
That's a behavior change, so should be on 5.4. |
| @@ -156,7 +156,7 @@ function (\SplFileInfo $file, $path) { | |||
| ), | |||
| \RecursiveIteratorIterator::LEAVES_ONLY | |||
| )); | |||
| uasort($files, 'strnatcmp'); | |||
| uksort($files, 'strnatcmp'); | |||
There was a problem hiding this comment.
that's a bug to me: sorting was supposed to happen on keys, not on values
There was a problem hiding this comment.
I get it, but it's been like that for years.
|
@fabpot I don't think it changes the behavior. casting the SplFileInfo to string (when passing the value to For the initial sort, this is an optimisation to try to have an array that is already partially sorted when merging the arrays of different paths. Using |
|
Thank you @lyrixx. |
It should be on path and not on info
and it's a big perf boost: https://blackfire.io/profiles/compare/27f409a5-73c7-4285-9b58-e631abbdb325/graph