[Validator] Add CidrValidator to allow validation of CIDR notations #43593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
dd88623 to
cd820ec
Compare
stof
reviewed
Oct 19, 2021
stof
reviewed
Oct 19, 2021
src/Symfony/Component/Validator/Resources/translations/validators.ro.xlf
Outdated
Show resolved
Hide resolved
CalinBolea
reviewed
Oct 19, 2021
src/Symfony/Component/Validator/Resources/translations/validators.ro.xlf
Show resolved
Hide resolved
stof
reviewed
Oct 19, 2021
src/Symfony/Component/Validator/Resources/translations/validators.en.xlf
Show resolved
Hide resolved
cd820ec to
58ccbae
Compare
derrabus
requested changes
Oct 19, 2021
d1ec95b to
6b20977
Compare
027a59d to
87339a4
Compare
Co-authored-by: Calin Bolea <calin.bolea@gmail.com>
87339a4 to
488ff61
Compare
derrabus
approved these changes
Oct 21, 2021
|
Hey, @stof could you please take a look at the changes requested by your code review ? Thanks! |
stof
approved these changes
Oct 22, 2021
|
Thank you @popsorin. |
|
Thank you @popsorin, looking forward to trying this out later. :) |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 25, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Add translations for CIDR constraint | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This PR backports the translations added in #43593. Additionally, I have added a German translation. Commits ------- 8903f8f [Validator] Add translations for CIDR constraint
This was referenced Nov 5, 2021
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 6, 2021
…psorin) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Add documentation for the Cidr Validator Hello everyone! This is the documentation for the Cidr validator and constraint.PR: symfony/symfony#43593 Please take a look and let me know if I need to change anything! Commits ------- 16de4a9 [Validator] Add documentation for the CidrValidator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a CIDR Constraint Validator that will check if a string is a valid CIDR notation.