Skip to content

[Framework][Secrets] Fix service definition when local vault is disabled #43627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2021
Merged

[Framework][Secrets] Fix service definition when local vault is disabled #43627

merged 1 commit into from
Oct 26, 2021
+2 −2

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 20, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Local vault can be disabled with the following configuration:

framework:
    secrets:
        local_dotenv_file: ~

This removes the service secrets.local_vault (code). The secrets:... commands support this by having $localVault argument nullable.

When configuration was moved from XML to PHP in #37216, the attribute on-invalid="ignore" of some services was left.

@carsonbot carsonbot added this to the 5.3 milestone Oct 20, 2021
@fabpot
Copy link
Member

fabpot commented Oct 26, 2021

Thank you @GromNaN.

@fabpot fabpot merged commit 68537b2 into symfony:5.3 Oct 26, 2021
@GromNaN GromNaN deleted the framework/5.3-local-vault-disabled branch October 26, 2021 12:24
@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @fabpot @carsonbot