Skip to content

[Console] Remove CompletionInterface #43628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

[Console] Remove CompletionInterface #43628

merged 1 commit into from
Oct 21, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets #43620 (comment)
License MIT
Doc PR N/A

@derrabus derrabus requested a review from chalasr as a code owner October 20, 2021 21:42
@carsonbot carsonbot added this to the 5.4 milestone Oct 20, 2021
@derrabus derrabus mentioned this pull request Oct 20, 2021
Closed
@derrabus derrabus linked an issue Oct 20, 2021 that may be closed by this pull request
[Console] Implementing bash completion in a forward-compatible way #43620
Closed
@derrabus
[Console] Remove CompletionInterface
cd49146 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the remove/completion-interface branch from 10ac83b to cd49146 Compare October 20, 2021 21:47
@derrabus derrabus changed the title [Console] Remove CompletionInterface [Console] Remove CompletionInterface Oct 20, 2021
@derrabus derrabus requested a review from wouterj October 21, 2021 08:28
@fabpot
Copy link
Member

fabpot commented Oct 21, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 540ee0a into symfony:5.4 Oct 21, 2021
This was referenced Oct 21, 2021
Closed
Merged
@derrabus derrabus deleted the remove/completion-interface branch October 21, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@wouterj wouterj wouterj approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Console] Implementing bash completion in a forward-compatible way
5 participants
@derrabus @fabpot @wouterj @chalasr @carsonbot