[PasswordHasher] Add autocompletion for security commands #43653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
wouterj
requested changes
Oct 22, 2021
There was a problem hiding this comment.
That was quick, thanks!
I have a question regarding @wouterj 's comment on the issue
Ignore my comment, I didn't know about this $userClasses property.
Also, the password is the first argument right now, should we swap it to be after user-class?
No, it's fine like this (autocompletion should support it this way).
Can you please also add tests? (see the other completion PRs for examples)
src/Symfony/Bundle/SecurityBundle/Command/UserPasswordEncoderCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PasswordHasher/Command/UserPasswordHashCommand.php
Outdated
Show resolved
Hide resolved
ca1e869 to
534c766
Compare
chalasr
reviewed
Oct 22, 2021
src/Symfony/Bundle/SecurityBundle/Command/UserPasswordEncoderCommand.php
Outdated
Show resolved
Hide resolved
534c766 to
b8addda
Compare
94noni
commented
Oct 22, 2021
src/Symfony/Component/PasswordHasher/Command/UserPasswordHashCommand.php
Show resolved
Hide resolved
b8addda to
5c0f762
Compare
5c0f762 to
49f45a9
Compare
wouterj
approved these changes
Oct 22, 2021
wouterj
approved these changes
Oct 29, 2021
fabpot
approved these changes
Oct 29, 2021
|
Thank you @94noni. |
|
Tests are failing on 5.4: https://github.com/symfony/symfony/runs/4055700364?check_suite_focus=true#step:8:2615 |
fabpot
added a commit
that referenced
this pull request
Oct 30, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [PasswordHasher] Fix completion tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #43653 (comment) | License | MIT | Doc PR | N/A Commits ------- fde1b0c [PasswordHasher] Fix completion tests
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43594 (comment)
I have a question regarding @wouterj 's comment on the issue
Also, the
passwordis the first argument right now, should we swap it to be afteruser-class?Still WIP, I am using
fishand want to test as well #43641