Skip to content

Fix logging of impersonator introduced in 5.3 #43659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Oct 23, 2021
Merged

Fix logging of impersonator introduced in 5.3 #43659

merged 0 commits into from
Oct 23, 2021

Conversation

johanwilfer
Copy link
Contributor

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR

This fixes logging of impersonator_username, if getUserIdentifier is implemented on the user provider that was introduced in 5.3

@carsonbot carsonbot added this to the 5.3 milestone Oct 22, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Oct 23, 2021

Thank you @johanwilfer.

@fabpot fabpot merged commit 2673ca9 into symfony:5.3 Oct 23, 2021
@fabpot fabpot force-pushed the impersonator_logging_fix branch from e2620f0 to 9abd4eb Compare October 23, 2021 07:08
@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@johanwilfer @carsonbot @fabpot @stof @chalasr