sorry, I've hidden my comment. The PR changed a lot from what I looked at yesterday night. I'll have to look again before sharing my opinion

I'm rewriting this solution to use more native bash and less PHP. Mainly to remove dependency of the input in BashOutput.

@wouterj I'm done with something more bash-native. The only limitation is with some values that are not unescaped: the token two\ words is not converted to two words in completion input.

It would be awesome if we find a way to add tests to the bash script (unit or functional).

It would be awesome if we find a way to add tests to the bash script (unit or functional).

I agree with that, but I have no idea how.

Hi!

I just tested it and I think this is perfect now you support both ways! I have 2 suggestions after quickly testing this:

1. What do you think about favoring quoted values with special chars (especially \ or )? For example:

   $ bin/console debug:form
   
   # would become:
   $ bin/console debug:form 'Symfony\Component\Form\Extension\Core\Type\
   
   # instead of:
   $ bin/console debug:form Symfony\\Component\\Form\\Extension\\Core\\Type\\
   

2. There is an error when the value only contains a quote:

   $ bin/console debug:form '
   [critical] Error thrown while running command "_complete -sbash -c2 -S5.4.0-DEV -ibin/console -idebug:form -i". Message: "The "--input" option requires a value."
                                The "--input" option requires a value.                                              _complete [-s|--shell SHELL] [-i|--input INPUT] [-c|--current CURRENT] [-S|--symfony SYMFONY]
   
   

@GromNaN Do you have time to have a look at Wouter's comments? I'd love to be able to merge this one to unlock some other PRs. Thank you.

Imho, we can also merge this one and fix both of them between beta1 and rc1. The feature is complete - it's just some minor polishing.

I'm going to make the requested changes tonight.

What do you think about favoring quoted values with special chars

By default, completion of a FQCN will contain only a single quote, since namespaces are different. Not a big deal.

Thank you @GromNaN.