Skip to content

[Translation] Add completion feature on translation pull and push commands #43672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

[Translation] Add completion feature on translation pull and push commands #43672

merged 1 commit into from
Oct 29, 2021

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Oct 23, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix (partially) #43594
License MIT
Doc PR

This PR adds completion for arguments and options on translation:pull and translation:push commands.

@carsonbot carsonbot added this to the 5.4 milestone Oct 23, 2021
@GromNaN GromNaN mentioned this pull request Oct 23, 2021
Closed
54 tasks
@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch 2 times, most recently from 76001ce to a8352e0 Compare October 25, 2021 15:40
@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch 3 times, most recently from 4f21b99 to f43980e Compare October 25, 2021 16:09
@welcoMattic
Copy link
Member Author

@GromNaN It's ready for review here

@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch from f43980e to d5eb582 Compare October 25, 2021 17:05
@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch 2 times, most recently from 48879bc to 08aa83d Compare October 26, 2021 07:48
@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch 2 times, most recently from 6207cd1 to 0cc8581 Compare October 26, 2021 08:18
@fabpot
Copy link
Member

fabpot commented Oct 26, 2021

Can you skip the tests for older versions of Symfony? Like in #43731 for instance.

@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch 2 times, most recently from e108eec to fa17c79 Compare October 26, 2021 08:44
@welcoMattic
Copy link
Member Author

welcoMattic commented Oct 26, 2021 •
edited
Loading

The last failing test seems to be related to #43688
Rebased on 5.4, everything is green.

@welcoMattic welcoMattic force-pushed the feat/trans-cmd-autocomplete branch from fa17c79 to 036b032 Compare October 27, 2021 07:22
@fabpot
Copy link
Member

fabpot commented Oct 29, 2021

Thank you @welcoMattic.

@fabpot fabpot merged commit 3f0f0ce into symfony:5.4 Oct 29, 2021
@welcoMattic welcoMattic deleted the feat/trans-cmd-autocomplete branch October 29, 2021 14:47
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Translation
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@welcoMattic @fabpot @stof @carsonbot