Skip to content

[FrameworkBundle] Add completion feature on translation:update command #43676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

[FrameworkBundle] Add completion feature on translation:update command #43676

merged 1 commit into from
Oct 29, 2021

Conversation

stephenkhoo
Copy link
Contributor

@stephenkhoo stephenkhoo commented Oct 23, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Part of #43594
License MIT
Doc PR -

Adding completion for translation:update.

  • locale
  • bundle
  • --format
  • --domain
  • --sort

Test for

  • locale
  • bundle
  • --format
  • --domain
  • --sort

Locale completion still under discussion in #43644 (review)

Locale and bundle test still not complete

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@stephenkhoo stephenkhoo force-pushed the feat/translation-update-autocomplete branch from b60f4d0 to 2186a20 Compare October 23, 2021 11:57
@stephenkhoo stephenkhoo marked this pull request as ready for review October 23, 2021 11:59
@carsonbot carsonbot added this to the 5.4 milestone Oct 23, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@stephenkhoo stephenkhoo changed the title Add completion feature on translation:update command #43594 [Translation] Add completion feature on translation:update command Oct 23, 2021
@GromNaN GromNaN mentioned this pull request Oct 23, 2021
Closed
54 tasks
@carsonbot carsonbot changed the title [Translation] Add completion feature on translation:update command Add completion feature on translation:update command Oct 23, 2021
@carsonbot carsonbot changed the title Add completion feature on translation:update command [FrameworkBundle] Add completion feature on translation:update command Oct 24, 2021
@stephenkhoo stephenkhoo force-pushed the feat/translation-update-autocomplete branch from bfd516f to 7cfc2b8 Compare October 25, 2021 11:28
@stephenkhoo
Copy link
Contributor Author

Added locale completion with Locales::getLocales()

will update again if there's other conclusion from #43644 (review)

Otherwise, it seems this PR has achieved its goal?

@stephenkhoo stephenkhoo force-pushed the feat/translation-update-autocomplete branch 2 times, most recently from 17aad65 to 6cd50d7 Compare October 26, 2021 03:53
@welcoMattic welcoMattic mentioned this pull request Oct 26, 2021
Merged
fabpot added a commit that referenced this pull request Oct 28, 2021
@fabpot
feature #43758 [FrameworkBundle] Rename translation:update to transla…
9f4fc3f 
…tion:extract (welcoMattic)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Rename translation:update to translation:extract

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | Fix #41411
| License       | MIT
| Doc PR        |

As we discussed in #41411, I've renamed `translation:update` to `translation:extract` which is a more accurate name.

`translation:update` will trigger a deprecation alert until 6.0 where we could remove it completely. For now all the code of the command lives in TranslationExtractCommand.php file, and TranslationUpdateCommand call it.

I think it should be merged after #43676.

It's my first attempt to deprecate something in Symfony, let me know if I forgot something or if I did something wrong.

Commits
-------

223f18e Rename translation:update to translation:extract
@fabpot fabpot force-pushed the feat/translation-update-autocomplete branch from f0e1711 to 2f301ae Compare October 29, 2021 14:49
@fabpot
Copy link
Member

fabpot commented Oct 29, 2021

Thank you @stephenkhoo.

@fabpot fabpot merged commit 375a89a into symfony:5.4 Oct 29, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN requested changes

@welcoMattic welcoMattic welcoMattic left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@stephenkhoo @carsonbot @fabpot @GromNaN @welcoMattic @derrabus