[RateLimiter] bug #42194 fix: sliding window policy to use microtime #43677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlekowski
commented
Oct 23, 2021
| @@ -72,4 +72,34 @@ public function testLongIntervalCreate() | |||
| $new = SlidingWindow::createFromPreviousWindow($window, 60); | |||
| $this->assertFalse($new->isExpired()); | |||
| } | |||
|
|
|||
| public function testCreateFromPreviousWindowUsesMicrotime() | |||
There was a problem hiding this comment.
These tests consistently pass after the changes. The old code would inconsistently fail, though (depend on the microtome(true) result at the moment of running the test.
fabpot
approved these changes
Oct 24, 2021
|
Thank you @jlekowski. |
|
This PR introduced a randomly failing test https://github.com/symfony/symfony/runs/3990643552?check_suite_focus=true#step:8:987. @jlekowski could you please have a look? |
|
@chalasr, I'll have a look at it. Thanks for letting me know. |
chalasr
added a commit
that referenced
this pull request
Oct 26, 2021
…se microtime - fix test (jlekowski) This PR was merged into the 5.4 branch. Discussion ---------- [RateLimiter] bug #42194 fix: sliding window policy to use microtime - fix test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #42194 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> As pointed out in the comment #43677 (comment), `RateLimitTest::testWaitUsesMicrotime()` fails intermittently. I have looked at all `PHPUnit` actions since the test was introduced and interestingly, the fails only occurred during `7.2` test, and the time difference was always ~1.3s. Commits ------- e616963 bug #42194 [RateLimiter] fix: sliding window policy to use microtime - fix test
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other parts of
RateLimiterusemicrotime(), while sliding window policy usestime()instead. That means the window may expire only up to 0.(9) seconds after the interval. Below an example that fails (window not expired) majority of the times (window is expired only if it starts e.g. at 1634992063.4999 and is checked at 1634992065.5000 - withtime()rounding it would be 3 seconds).