Skip to content

Add suggestions for the option 'format' of lints commands: twig, yaml and xliff #43680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2021
Merged

Add suggestions for the option 'format' of lints commands: twig, yaml and xliff #43680

merged 1 commit into from
Oct 24, 2021

Conversation

makraz
Copy link
Contributor

@makraz makraz commented Oct 23, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #43594
License MIT
Doc PR -

Adding Bash completion for the following commands:

  • lint:twig (--format)
  • lint:xliff (--format)
  • lint:yaml (--format)

@makraz makraz requested a review from xabbuh as a code owner October 23, 2021 18:29
@carsonbot carsonbot added this to the 5.4 milestone Oct 23, 2021
@GromNaN GromNaN mentioned this pull request Oct 23, 2021
Closed
54 tasks
GromNaN
GromNaN requested changes Oct 23, 2021
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 commands have the same pattern and does not use the DescriptorHelper class. The suggestions could be simply hardcoded in each class.

@fabpot fabpot mentioned this pull request Oct 24, 2021
Closed
@fabpot fabpot merged commit 567eb19 into symfony:5.4 Oct 24, 2021
@makraz makraz deleted the hamza/console-suggestions branch October 24, 2021 10:26
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@makraz @fabpot @GromNaN @carsonbot