Skip to content

[Messenger] move username/password fix to non-deprecated Connection class #43695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

[Messenger] move username/password fix to non-deprecated Connection class #43695

merged 1 commit into from
Oct 25, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 25, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.3 milestone Oct 25, 2021
@xabbuh xabbuh requested a review from sroze as a code owner October 25, 2021 14:58
@xabbuh
Copy link
Member Author

xabbuh commented Oct 25, 2021

This issue was initially fixed on the 4.4 branch in #43484 but broke when merging 4.4 into 5.3.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 006d345 into symfony:5.3 Oct 25, 2021
@xabbuh xabbuh deleted the pr-43484 branch October 25, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot