drop support for configuring Symfony with Composer 1 #43813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 29, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
| @@ -235,7 +235,7 @@ class FrameworkExtension extends Extension | |||
| public function load(array $configs, ContainerBuilder $container) | |||
| { | |||
| if (!class_exists(InstalledVersions::class)) { | |||
| trigger_deprecation('symfony/framework-bundle', '5.4', 'Configuring Symfony without the Composer Runtime API is deprecated. Consider upgrading to Composer 2.'); | |||
| throw new LogicException('The Composer Runtime API is required to configure Symfony. Consider upgrading to Composer 2.'); | |||
There was a problem hiding this comment.
As now it throws ex, maybe the word Consider is no more appropriate, but more You must upgrade no?
There was a problem hiding this comment.
we usually use "should", so "consider" is fine to me
There was a problem hiding this comment.
This should be done using requirements on composer-runtime-api in the composer.json, which will then mean that this exception is never triggered...
1dfb031 to
3f1d476
Compare
|
I missed that we already have #43788 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.