[Intl] Update the ICU data to 70.1 - 5.3 #43814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7bab272 to
e17639b
Compare
stof
reviewed
Oct 29, 2021
| @@ -330,6 +330,10 @@ | |||
| 0 => 'LRD', | |||
| 1 => 'Ego Dollar obodo Liberia', | |||
| ], | |||
| 'LSL' => [ | |||
| 0 => 'LSL', | |||
| 1 => 'This is not a translation', | |||
There was a problem hiding this comment.
looks like the ICU release contains a weird thing here...
| 'BRB' => 76, | ||
| 'BRC' => 76, | ||
| 'BRE' => 76, | ||
| 'BRN' => 76, |
There was a problem hiding this comment.
would be great to make this array deterministic, to avoid shuffling in between updates (looks like it is sorted by value, but values are not unique)
There was a problem hiding this comment.
do we care about diff in generated data?
There was a problem hiding this comment.
Well, we removed the ICU version from all those generated files precisely to reduce meaningless diffs.
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dedicated to 5.3 because we switch from .json file to .PHP file