Skip to content

feat: add completion for DebugAutowiring search argument #43838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

feat: add completion for DebugAutowiring search argument #43838

merged 1 commit into from
Nov 4, 2021

Conversation

eclairia
Copy link
Contributor

@eclairia eclairia commented Oct 30, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #43594
License MIT
Doc PR -

Adding Bash completion debug:autowiring command.

@carsonbot carsonbot added this to the 5.4 milestone Oct 30, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@eclairia eclairia force-pushed the feature-debug-completion branch from 0ebd8e8 to 2ab8199 Compare October 30, 2021 12:30
GromNaN
GromNaN requested changes Oct 30, 2021
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eclairia. Here is an opinionated feedback.

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php Outdated

$searchNormalized = $this->getSearchNormalized($input->getArgument('search'));

$serviceIds = array_filter($serviceIds, function ($serviceId) use ($searchNormalized) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the class names (service IDs) don't need to be normalized for completion. Suggestions would be identical to defined service IDs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GromNaN for the review.

I removed the completion normalization for class names.
I also added the class alias into the completion since the search argument can also take an alias in value.

@GromNaN GromNaN mentioned this pull request Oct 30, 2021
Closed
54 tasks
@eclairia eclairia force-pushed the feature-debug-completion branch 3 times, most recently from 5cc8ca7 to 8c1d58d Compare October 31, 2021 10:55
@eclairia eclairia force-pushed the feature-debug-completion branch from f74ed1b to afd9b92 Compare November 4, 2021 14:45
@fabpot fabpot force-pushed the feature-debug-completion branch from afd9b92 to ef8c518 Compare November 4, 2021 14:48
@fabpot
Copy link
Member

fabpot commented Nov 4, 2021

Thank you @eclairia.

@fabpot fabpot merged commit 7acf15e into symfony:5.4 Nov 4, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@eclairia @carsonbot @fabpot @GromNaN