Add completion for debug:twig #43846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Nov 1, 2021
fabpot
requested changes
Nov 1, 2021
|
@fabpot disabled IDE and tried to clean my code. |
|
You can ignore fabbot :) |
OK 🤣 |
wouterj
requested changes
Nov 1, 2021
54 tasks
|
@wouterj thanks for code review. I missed that we have two methods for execute() displayGeneralText() and displayGeneralJson() |
wouterj
approved these changes
Nov 1, 2021
Comment on lines
603
to
610
| $names = []; | ||
| $paths = $this->getLoaderPaths(); | ||
|
|
||
| foreach ($paths as $namespace => $paths) { | ||
| $names[] = $namespace; | ||
| } | ||
|
|
||
| return $names; |
There was a problem hiding this comment.
This can be replaced with array_keys($this->getLoaderPaths()) (and can be inlined on line 118 directly)
|
|
||
| private function getAvailableFormatOptions(): array | ||
| { | ||
| return ['text', 'json']; |
|
@wouterj thanks optimized code :) |
fabpot
approved these changes
Nov 1, 2021
|
Thank you @StaffNowa. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add completion for debug:twig