Skip to content

[RateLimiter] Increase delta in limiter tests #43847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Oct 30, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Tests from PR might randomly fail 1 2

I increased delta like in this test.

image

image

@fabpot @Nyholm please review

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Nov 1, 2021

Thank you @wkania.

@fabpot fabpot merged commit f3c19ed into symfony:5.3 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants