[FrameworkBundle] Add completion for workflow:dump #43848
Conversation
|
|
||
| private function getAvailableNameArguments(): array | ||
| { | ||
| $names = []; |
There was a problem hiding this comment.
why not inject them from the FrameworkExtension like inside the workflow.registry?
doing this, we can remove the $container::has() from this class inside the execute() method
we check if the passed name is inside the array of workflows (workflow+statemachine) injected
There was a problem hiding this comment.
I see container get definition but cannot inject into command 😢 do I need get configs or whole registry class 🤔
There was a problem hiding this comment.
I think just do not know how. If good understand I need inject configuration to load this one
$config['workflows']
There was a problem hiding this comment.
I think just do not know how. If good understand I need inject configuration to load this one
pass this (or a new array computed from this list) inside the command construct, then in the execute and the complete methods you can get those and handle the logic
There was a problem hiding this comment.
@StaffNowa as discussed on slack, I've sent you an example you can pick then continue working on this :)
|
|
||
| private function getAvailableDumpFormatOptions(): array | ||
| { | ||
| return ['puml', 'mermaid', 'dot']; |
There was a problem hiding this comment.
maybe create private consts? and refactor the switch/case above
src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Command/WorkflowDumpCommandTest.php
Show resolved
Hide resolved
|
Thank you @StaffNowa. |
Add completion for workflow:dump
We do not have tests here at all