Skip to content

Add completion for DebugConfig name and path arguments #43850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

Add completion for DebugConfig name and path arguments #43850

merged 1 commit into from
Nov 4, 2021

Conversation

eclairia
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #43594
License MIT
Doc PR -

Adding Bash completion for debug:config command.

@carsonbot carsonbot added this to the 5.4 milestone Oct 30, 2021
@eclairia eclairia force-pushed the feature-debug-config-completion branch 2 times, most recently from a38325b to 6403892 Compare October 31, 2021 10:49
@GromNaN GromNaN mentioned this pull request Nov 1, 2021
Closed
54 tasks
@eclairia eclairia force-pushed the feature-debug-config-completion branch from 6403892 to a75f1d7 Compare November 1, 2021 13:21
@eclairia eclairia force-pushed the feature-debug-config-completion branch from 0af9d95 to 6665f8e Compare November 4, 2021 14:57
@eclairia eclairia force-pushed the feature-debug-config-completion branch from 6665f8e to f8ad3ec Compare November 4, 2021 15:08
@fabpot fabpot changed the title feat: add completion for DebugConfig name and path arguments Add completion for DebugConfig name and path arguments Nov 4, 2021
@eclairia eclairia force-pushed the feature-debug-config-completion branch from f8ad3ec to f5e26ba Compare November 4, 2021 16:06
GromNaN
GromNaN approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are not related to the changes.

@fabpot fabpot force-pushed the feature-debug-config-completion branch from f5e26ba to 3bcffc2 Compare November 4, 2021 17:55
@fabpot
Copy link
Member

fabpot commented Nov 4, 2021

Thank you @eclairia.

@fabpot fabpot merged commit d77697c into symfony:5.4 Nov 4, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[DX] Add completion to Symfony commands
4 participants
@eclairia @fabpot @GromNaN @carsonbot