Skip to content

[Messenger] Add completion to command messenger:consume #43891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

[Messenger] Add completion to command messenger:consume #43891

merged 1 commit into from
Nov 3, 2021

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 2, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #43594
License MIT
Doc PR -

Command messenger:consume takes a list of receivers that should be unique. The values for option --bus where easy to inject into the command.

I skipped the option --queue whose values are defined deep in the transport options.

@GromNaN GromNaN requested a review from sroze as a code owner November 2, 2021 20:57
@carsonbot carsonbot added this to the 5.4 milestone Nov 2, 2021
@GromNaN GromNaN mentioned this pull request Nov 2, 2021
Closed
54 tasks
@fabpot
Copy link
Member

fabpot commented Nov 3, 2021

@GromNaN Can you have a look at the tests, they seem broken by this PR.

@GromNaN GromNaN force-pushed the completion/messenger-consume branch from 9d2f912 to c3327b7 Compare November 3, 2021 12:36
@GromNaN GromNaN force-pushed the completion/messenger-consume branch 2 times, most recently from 799c274 to 5adc94d Compare November 3, 2021 13:28
@GromNaN GromNaN force-pushed the completion/messenger-consume branch from 5adc94d to f99f586 Compare November 3, 2021 13:35
@GromNaN
Copy link
Member Author

GromNaN commented Nov 3, 2021

Tests are green @fabpot.

@fabpot
Copy link
Member

fabpot commented Nov 3, 2021

Thank you @GromNaN.

@fabpot fabpot merged commit 0828a91 into symfony:5.4 Nov 3, 2021
@GromNaN GromNaN deleted the completion/messenger-consume branch November 3, 2021 14:59
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stloyd stloyd stloyd approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@GromNaN @fabpot @stloyd @carsonbot