Skip to content

[Security][SecurityBundle] Backport type fixes #43899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

[Security][SecurityBundle] Backport type fixes #43899

merged 1 commit into from
Nov 3, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 3, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Backports from #43872
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 5.4 milestone Nov 3, 2021
@carsonbot carsonbot changed the title Backport type fixes [Security][SecurityBundle] Backport type fixes Nov 3, 2021
@derrabus derrabus force-pushed the types/security-backports branch from b5710ef to a6b36ef Compare November 3, 2021 09:16
nicolas-grekas
nicolas-grekas approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just please fix fabbot's report about deprecations)

@fabpot
Copy link
Member

fabpot commented Nov 3, 2021

Can you also rebase?

@derrabus derrabus force-pushed the types/security-backports branch from a6b36ef to 8f8b167 Compare November 3, 2021 14:18
@derrabus
[Security] Backport type fixes
8ac471b 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the types/security-backports branch from 8f8b167 to 8ac471b Compare November 3, 2021 14:30
@derrabus
Copy link
Member Author

derrabus commented Nov 3, 2021

ready

@fabpot
Copy link
Member

fabpot commented Nov 3, 2021

Thank you @derrabus.

@fabpot fabpot merged commit aa68efc into symfony:5.4 Nov 3, 2021
@derrabus derrabus deleted the types/security-backports branch November 21, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Security SecurityBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@derrabus @fabpot @nicolas-grekas @stof @chalasr @carsonbot