[DependencyInjection] only allow ReflectionNamedType for ServiceSubscriberTrait
#43922
Conversation
|
Can you provide a test that covers your change? |
|
Test added. Regarding the failing CI: when I had this issue in #42238, this was how I solved - not sure what to do here... |
|
The test case should be moved to |
|
@nicolas-grekas given that the test relies on the DI component, this would be wrong. I think that the right fix is to bump the min version of |
|
The test should be updated to not rely on the DI component. There is no need for this dep. |
4844ddc to
d5feef6
Compare
|
Ok, test has been moved. |
d5feef6 to
d9dcc35
Compare
d9dcc35 to
b616042
Compare
|
Thank you @kbond. |
|
@kbond I think I might have messed up the merging this change up to 5.4 and 6.0. Can you please have a look? |
|
@derrabus, 5.4 just needs a test marked as legacy. 6.0 needs some work to re-remove the deprecation layer. Do you want me to open PR(s)? |
That would be awesome. ❤️ |
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] mark test as legacy | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Ref: #43922 (comment) `@derrabus`, once this makes it into 6.0 give me a ping and I'll open a PR to fix the 6.0 issues. Commits ------- 0b6cfcb [DependencyInjection] mark test as legacy
This PR was merged into the 6.0 branch. Discussion ---------- [DependencyInjection] clean up merge issue | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Cleans up merge issue from #43922. Commits ------- ed30e4c [DependencyInjection] remove deprecation layer
I'll follow this up with a PR on 5.4 to allow union/intersections when using the
SubscribedServiceattribute (onceServiceSubscriberInterfacesupports this).