Skip to content

[FrameworkBundle] Fix logic in workflow:dump between workflow name and workflow id #43940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

[FrameworkBundle] Fix logic in workflow:dump between workflow name and workflow id #43940

merged 1 commit into from
Nov 5, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Nov 5, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43938
License MIT

As described in #43938 (comment)
the command need a workflow name as argument, but the array contains workflows ids (prefix workflow|state_machine)

@94noni 94noni requested a review from lyrixx as a code owner November 5, 2021 11:17
@carsonbot carsonbot added this to the 5.4 milestone Nov 5, 2021
StaffNowa
StaffNowa approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@StaffNowa StaffNowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix ;)

@noniagriconomie
Copy link
Contributor

@StaffNowa really my bad maybe wrong explanation on your PR!
conflicts between the workflow name pass as argument and the workflows ids passed in constructor :)

lyrixx
lyrixx approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot
Copy link
Member

fabpot commented Nov 5, 2021

Thank you @94noni.

@fabpot fabpot merged commit 8a9e826 into symfony:5.4 Nov 5, 2021
@94noni 94noni deleted the fx-workflow-dump branch November 6, 2021 10:36
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@StaffNowa StaffNowa StaffNowa approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Workflow] Command workflow:dump not working
6 participants
@94noni @noniagriconomie @fabpot @lyrixx @StaffNowa @carsonbot