Skip to content

[HttpKernel] Make sure a serialized DumpDataCollector can be unserialized #43946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 5, 2021

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

This bugfix prevents an error from being thrown when fetching the debug toolbar:

Typed property Symfony\Component\HttpKernel\DataCollector\DumpDataCollector::$stopwatch must not be accessed before initialization

I think, it makes sense to backport the test to lower branches.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@carsonbot carsonbot changed the title Make sure a serialized DumpDataCollector can be unserialized [HttpKernel] Make sure a serialized DumpDataCollector can be unserialized Nov 5, 2021
@carsonbot carsonbot added this to the 6.0 milestone Nov 5, 2021
@fabpot
Copy link
Member

fabpot commented Nov 5, 2021

Thank you @derrabus.

@fabpot fabpot merged commit aaf4c32 into symfony:6.0 Nov 5, 2021
@derrabus derrabus deleted the bugfix/type-error-on-unserialize branch November 5, 2021 18:30
@fabpot fabpot mentioned this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants