[Loco] Fix Loco Provider ID and pull & push local messages reading #43967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 8, 2021
|
Thank you @welcoMattic. |
|
@fabpot I just realized that I opened this PR on 5.4 instead of 5.3, since it is a bugfix. Sorry |
stof
reviewed
Nov 9, 2021
| @@ -171,6 +171,7 @@ private function createAssets(array $keys): array | |||
| foreach ($keys as $key) { | |||
| $responses[$key] = $this->client->request('POST', 'assets', [ | |||
| 'body' => [ | |||
| 'id' => $key, | |||
There was a problem hiding this comment.
be careful. Translation keys are only unique per domain, not globally. so they might note be suitable as loco ids.
There was a problem hiding this comment.
You are right, so may be we can concatenate the domain as prefix or suffix to the key?
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes Loco push new messages and avoiding Loco auto-generation of ID for each new messages (which use dash notation instead of dot notation IIRC).
And it fixes also the Translation push & pull commands when they read local messages for multiple domains.