[HttpKernel] allow ignoring kernel.reset methods that don't exist #43983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Nov 9, 2021
src/Symfony/Component/HttpKernel/DependencyInjection/ResettableServicePass.php
Show resolved
Hide resolved
ogizanagi
approved these changes
Nov 9, 2021
fabpot
approved these changes
Nov 9, 2021
|
Thank you @nicolas-grekas. |
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a service is built by a factory, we don't always know if the resulting instance will implement
ResetIntefaceor not.One such service is
http_client:HttpClient::create()might return a curl-one or a native-one, and only the former is resettable.This PR makes it possible to make a reset conditional, aka by ignoring when the reset method doesn't exist.
This is both a new feature for HttpKernel and a bugfix for the
http_clientservice.That's why I'm targeting 5.4.