[Translation] [Loco] Generate id parameter instead of letting Loco do it #43990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9a3310 to
18cfc68
Compare
stof
reviewed
Nov 10, 2021
|
Is there anything "breaking" if the user now switch to the "new" logic? |
|
As it's already broken for all projects without the asset alias "name", I don't think so. And for all others projects with this asset alias, I made the check of the prefix key to check if the key starts with the domain name or not. To be sure, I will made a test project with and without assay alias and process some tests, I'll let you know. |
93d0550 to
06a9ff1
Compare
nicolas-grekas
approved these changes
Nov 15, 2021
fabpot
approved these changes
Nov 16, 2021
06a9ff1 to
1a44526
Compare
|
Thank you @welcoMattic. |
This was referenced Nov 18, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we get rid of the auto generated id from Loco (which generate id with dash notation). The counterpart is that we have to iterate over the fetched catalogues to transform the received translation keys, I'm not 100% sure about the performance impact on very large catalogues.