Skip to content

[ErrorHandler] fix parsing @param with dollars in the description #44013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2021
Merged

[ErrorHandler] fix parsing @param with dollars in the description #44013

merged 1 commit into from
Nov 13, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43936
License MIT
Doc PR -

@carsonbot carsonbot added this to the 5.4 milestone Nov 11, 2021
@carsonbot
Copy link

Hey!

I think @fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Nov 13, 2021

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 0d15daf into symfony:5.4 Nov 13, 2021
@nicolas-grekas nicolas-grekas deleted the eh-dollars branch November 13, 2021 14:10
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@fancyweb fancyweb fancyweb approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug ErrorHandler Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

False positives in DebugClassLoader when @param documentation mentions another $variable
4 participants
@nicolas-grekas @carsonbot @fabpot @fancyweb