[SecurityBundle] Fix listing listeners in profiler when authenticator manager is disabled #44016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Nov 12, 2021
| @@ -233,7 +233,11 @@ | |||
| {% else %} | |||
| <tr> | |||
| <th>listeners</th> | |||
| <td>{{ collector.firewall.listeners is empty ? '(none)' : profiler_dump(collector.firewall.listeners, maxDepth=1) }}</td> | |||
| <td> | |||
| {% if collector.firewall.listeners is defined %} | |||
There was a problem hiding this comment.
Should'nt we display something is the listeners is not defined?
what's about (not tested)
<td>{{ collector.firewall.listeners|default ? profiler_dump(collector.firewall.listeners, maxDepth=1) : '(none)' }}</td>
|
@94noni Can you show the output of composer show for your application when you run into this? |
|
@xabbuh here you are: FYI, it is when the After upgrading to the new security logic, there is no problem |
|
The bug was introduced in 3ec5e96#diff-e0854f6b2ba3388ec69473baf0dcfcba7db87daad4a3efc86d3a063a00407830R197 where I think we can always use |
|
@chalasr I've remade the PR, is that what you had in mind? feel free to take over if needed :) |
… manager is disabled
|
It is but I changed my mind meanwhile :) Just force-pushed your PR. |
chalasr
approved these changes
Nov 12, 2021
fabpot
approved these changes
Nov 12, 2021
|
Thank you @94noni. |
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to upgrade an app from v4.4 to v5.4 beta1
when going to the profiler > security panel, I got this error:
Neither the property "listeners" nor one of the methods "listeners()", "getlisteners()"/"islisteners()"/"haslisteners()" or "__call()" exist and have public access in class "Symfony\Component\VarDumper\Cloner\Data".This PR tries to fix this in Twig, I do not know the collector logic to fix differently