[Process] intersect with getenv() to populate default envs #44070
Conversation
nicolas-grekas
commented
Nov 16, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #44066 |
| License | MIT |
| Doc PR | - |
72c52b9 to
77f8f52
Compare
77f8f52 to
f608f0b
Compare
| $env = getenv(); | ||
| $env = array_intersect_key($env, $_SERVER) ?: $env; |
There was a problem hiding this comment.
This means if the current running process has added env vars putenv(), they still won't be detected though. One has to update $_SERVER + do putenv() for it to be taken into account.
There was a problem hiding this comment.
That's right, we are intentionally not compatible with putenv() here, because using putenv leads to blank pages in Windows
| $env = []; | ||
|
|
||
| foreach ($_SERVER as $k => $v) { | ||
| if (\is_string($v) && false !== $v = getenv($k)) { |
There was a problem hiding this comment.
Removal of the is_string check seems to be allowing arrays to get in to the env array as values. This causes an error "ErrorException Array to string conversion" when the env vars are read as a string in the start() method()
There was a problem hiding this comment.
Already fixed, see #44208
Please create issue instead of commenting on closed PRs to report issue btw.