Skip to content

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

When making voters cacheable, I forgot to update the ExpressionVoter.

The ExpressionVoter only supports attributes that are an instance of Expression. So, the Expression does not support any attribute of type string.

FYI: When an attribute is not a string, the AccessDessision manager considers that all voters support it.

@fabpot
Copy link
Member

fabpot commented Nov 17, 2021

Thank you @jderusse.

@fabpot fabpot merged commit 8ca777b into symfony:5.4 Nov 17, 2021
This was referenced Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants