[WIP][Translations][tests] Tests for PluralizationRules. #4412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything pending in this PR? |
| * | ||
| * @return array with nplural together with langcodes | ||
| */ | ||
| public function failingLangcodes() |
There was a problem hiding this comment.
I would say someone should check the failingLangcodes().
fabpot
added a commit
that referenced
this pull request
Jul 9, 2012
Commits ------- 3462afc Tests for PluralizationRules. Discussion ---------- [WIP][Translations][tests] Tests for PluralizationRules. Currently we have no tests PluralizationRules. This patch is an initial one to show we have not enough langcodes in PluralizationRules. I hope this gets in so others can fix the missing langcodes. I'm waiting for [RFC [MessageCatalogue*] Add Metadata to MessageCatalogue](#4399) to get in to continue working on the [[WIP]: Allow Drupal to use Translate component](#4249). --------------------------------------------------------------------------- by travisbot at 2012-05-25T14:38:37Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1433558) (merged 3462afc into 023dbf8). --------------------------------------------------------------------------- by drak at 2012-07-01T09:47:05Z Is there anything pending in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have no tests PluralizationRules. This patch is an initial one to show we have not enough langcodes in PluralizationRules.
I hope this gets in so others can fix the missing langcodes.
I'm waiting for RFC [MessageCatalogue*] Add Metadata to MessageCatalogue to get in to continue working on the [WIP]: Allow Drupal to use Translate component.