Skip to content

[SecurityBundle] Remove outdated conditions based on authenticatorManagerEnabled #44130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2021
Merged

[SecurityBundle] Remove outdated conditions based on authenticatorManagerEnabled #44130

merged 1 commit into from
Nov 19, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Nov 18, 2021

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The authenticator manager must be enabled as of 6.0.

symfony/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php

Line 94 in a1c9f10

throw new InvalidConfigurationException('"security.enable_authenticator_manager" must be set to "true".');

@chalasr chalasr requested a review from wouterj as a code owner November 18, 2021 17:16
@carsonbot carsonbot added this to the 6.0 milestone Nov 18, 2021
@fabpot
Copy link
Member

fabpot commented Nov 19, 2021

Thank you @chalasr.

@fabpot fabpot merged commit ba6de87 into symfony:6.0 Nov 19, 2021
@chalasr chalasr deleted the sec-dead-checks branch November 19, 2021 10:30
@fabpot fabpot mentioned this pull request Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

@wouterj wouterj wouterj approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chalasr @fabpot @jderusse @wouterj @welcoMattic @carsonbot