-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] [Mailgun] Allow multiple TagHeaders with MailgunApiTransport #44137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @kbond, you implemented the original version for Mailgun TagHeader support, are you the right person to ask for a review/feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping @starred-gijs! This looks good to me but let's add as a new feature so you'll need to target 6.1.
Thanks for your reply! Any change I can convince you to handle this as a bug? 😄 |
I admit this feels like a bit of a grey area personally and I know the frustration of having to wait a few versions for a fix like this. I'm falling back on the established Symfony process and this would be considered a feature. The code isn't currently broken, it just doesn't allow a specific feature provided by Mailgun. |
Oke fair enough, it was worth a try. I will rebase and target 6.1 :) |
Awesome, and thanks for understanding :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor
Thank you @starred-gijs. |
@OskarStark Thanks for the review! |
No problem, thanks for reaching out |
I've made the change myself while merging as it was a small one. |
Not to disrespect anyone, but how is this PR different? #45274 edit: I mean the target branch :) |
None taken :)
I chose #45274 as a bug fix because multiple tags were already implemented, tested, and documented for Mailchimp. The way they were added was not consistent. |
Mailgun allows you to set 3 tags per message but the current implementation in MailgunApiTransport, any consecutive TagHeader will override the previous one. Because it uses FormDataPart to build the payload, by using a integer key, it allows to set multiple parts with the same name #38323
The MailgunHttpTransport already supports multiple TagHeaders and I added a test to prove that.